Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding conflict error to error definition #107

Merged
merged 3 commits into from
Dec 12, 2023
Merged

feat: adding conflict error to error definition #107

merged 3 commits into from
Dec 12, 2023

Conversation

adriantam
Copy link
Member

@adriantam adriantam commented Oct 25, 2023 •
edited
Loading

Description

Adding new HTTP return code (409) which will be returned for conflict

References

First step in addressing openfga/openfga#1080
Corresponding change openfga/openfga#1179

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@adriantam adriantam requested a review from a team as a code owner October 25, 2023 01:48
miparnisari
miparnisari previously approved these changes Nov 22, 2023
View reviewed changes
adriantam added a commit that referenced this pull request Nov 27, 2023
@adriantam
feat: introduce 409 conflict error code
871b2d5 
Close #107
@adriantam
Copy link
Member Author

Updated to avoid introducing new internal code

adriantam added a commit that referenced this pull request Nov 27, 2023
@adriantam
feat: introduce 409 conflict error code
20d47f8 
Close #107
@adriantam adriantam mentioned this pull request Nov 30, 2023
Merged
4 tasks
jon-whit
jon-whit reviewed Dec 7, 2023
View reviewed changes
openfga/v1/openapi.proto Outdated Show resolved Hide resolved
@miparnisari miparnisari merged commit 061d8d8 into main Dec 12, 2023
7 checks passed
@miparnisari miparnisari deleted the feat/write_conflict branch December 12, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miparnisari miparnisari miparnisari approved these changes

@jon-whit jon-whit Awaiting requested review from jon-whit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriantam @jon-whit @miparnisari